Skip to content

[ROCKETMQ-8] Standardize build script.#5

Closed
lollipopjin wants to merge 3 commits into
apache:masterfrom
lollipopjin:master
Closed

[ROCKETMQ-8] Standardize build script.#5
lollipopjin wants to merge 3 commits into
apache:masterfrom
lollipopjin:master

Conversation

@lollipopjin

@lollipopjin lollipopjin commented Dec 23, 2016

Copy link
Copy Markdown
Contributor

Step1:
Remove original scripts.

JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-8

@vongosling

Copy link
Copy Markdown
Member

Sorry, we don't merge this PR.
IMO, there is step 2 you must finish :-)

@lollipopjin lollipopjin changed the title [ROCKETMQ-8]Standardize build script using maven wrapper. [ROCKETMQ-8] Standardize build script. Dec 23, 2016
@lollipopjin

lollipopjin commented Dec 23, 2016

Copy link
Copy Markdown
Contributor Author

@vongosling
I have finished all steps.
All methods to build RocketMQ seems ok in my local env.

@vongosling

Copy link
Copy Markdown
Member

Thanks for your PR.
I have checked it. It's seems ok for me. please @stevenschew @zhouxinyu review it.

@zhouxinyu

Copy link
Copy Markdown
Member

It seems ok.

@stevenschew

Copy link
Copy Markdown
Contributor

review Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants